fix: treat lockfile-only package changes as releasable#3905
Open
haosenwang1018 wants to merge 2 commits intomodelcontextprotocol:mainfrom
Open
fix: treat lockfile-only package changes as releasable#3905haosenwang1018 wants to merge 2 commits intomodelcontextprotocol:mainfrom
haosenwang1018 wants to merge 2 commits intomodelcontextprotocol:mainfrom
Conversation
olaservo
reviewed
Apr 12, 2026
Member
olaservo
left a comment
olaservo
left a comment
There was a problem hiding this comment.
The core fix looks good — lockfile-only changes should absolutely be treated as releasable, and the test is thorough (creates a real temp git repo).
One small ask: the README.md comma fix (line 144) is unrelated scope. Could you split that into a separate commit or drop it from this PR? Keeps the git history clean.
Otherwise this is ready to go.
This review was assisted by Claude Code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/release.pytreat any tracked file change inside a package directory as a releasable change.pyand.tsfiles, which skipped lockfile-only package updatesuv.lockchangesWhy
Issue #3870 shows that a package can change between tags via
uv.lockalone, but the current release script skips bumping its version becausehas_changes()only counts.pyand.tsfiles.That leaves
pyproject.tomlon an older version even though the tagged release includes a changed package directory.Testing
python -m pytest tests/test_release.py -qFixes #3870